Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add branch delete/forget glob:pattern, deprecate --glob option #2408

Merged
merged 6 commits into from
Oct 21, 2023

Conversation

yuja
Copy link
Contributor

@yuja yuja commented Oct 21, 2023

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

yuja added 6 commits October 21, 2023 09:55
The Display impl helps to format error messages. Since both Regex and
glob::Pattern implement Display, it's probably okay for our type to copy that.
The error message for unmatched patterns is adjusted so that it can be applied
to both exact and glob patterns.
find_forgettable_branches() is unchanged for now. I might want to rewrite it
to not remove untracked remote branches (because untracked branches aren't
associated with the local counterparts.)
The parse rule is lax compared to revset. We could require the pattern to be
quoted, but that would mean glob patterns have to be quoted like 'glob:"foo*"'.
…yntax

I'm not going to remove --glob anytime soon, but I won't add --glob option to
new commands.
@martinvonz martinvonz changed the title add branch delete/foget glob:pattern, deprecate --glob option add branch delete/forget glob:pattern, deprecate --glob option Oct 21, 2023
lib/src/str_util.rs Show resolved Hide resolved
@yuja yuja merged commit 8dbe12d into jj-vcs:main Oct 21, 2023
14 checks passed
@yuja yuja deleted the push-xyxwslpqozsq branch October 21, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants